Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Poco with std::filesystem in dynamic library loading code #38081

Draft
wants to merge 1 commit into
base: release-next
Choose a base branch
from

Conversation

jclarkeSTFC
Copy link
Contributor

Use std::filesystem methods and classes instead of Poco in the code loading dynamic libraries. Also threw in replacing boost string methods with std equivalents in DllOpen.cpp.

This is part of the work investigating #38011

To test:

Check libraries are loaded correctly by setting logging to Debug and checking that e.g. MantidCrystal.dll is loaded, along with all other .dll files in the bin folder. In a package some of those files will appear in the plugins folder.

This does not require release notes because it has no effect on the user.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

Use std::filesystem methods and classes instead of Poco in the code
loading dynamic libraries. Also threw in replacing boost string
methods with std equivalents in DllOpen.cpp.
@jclarkeSTFC jclarkeSTFC added the ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS label Sep 25, 2024
@jclarkeSTFC jclarkeSTFC added this to the Release 6.11 milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant