Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operation help goes to wrong page #820

Closed
dtasev opened this issue Jan 14, 2021 · 1 comment · Fixed by #832
Closed

Operation help goes to wrong page #820

dtasev opened this issue Jan 14, 2021 · 1 comment · Fixed by #832
Assignees

Comments

@dtasev
Copy link
Contributor

dtasev commented Jan 14, 2021

Summary

The help for any filter below the first separator (--------) goes to the wrong help page.

This seems to happen in the mantidimaging/gui/windows/operations/view.py::open_help_webpage function, the currentIndex() no longer returns the correct index as we now have separators inside the list.

A crude fix for this was done in #821 but that will be contained only for the release branch.

Steps To Reproduce

  • Open Operations window
  • Select Divide
  • Click the ? for help
  • The web page opened will not be for the divide filter

Expected Behaviour

The help page should always be correct

Context

Failure Logs

Screenshot(s)

@samtygier-stfc
Copy link
Collaborator

#821 Merged, but keeping bug open for more general fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants