Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wrong help page being opened #821

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

dtasev
Copy link
Contributor

@dtasev dtasev commented Jan 14, 2021

Description

Subtracts 1 or 2 from the current index depending on how far the selected operation is. This fixes going to the
wrong page, but due to it not being a good way of fixing this, it will only be for the release 2.0 where we won't be adding any more operations.

Testing

  • Open Operations window
  • Select Divide
  • Click the ? for help
  • The web page opened will not be for the divide filter

Acceptance Criteria

The correct help page is opened every time.

Documentation

How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes

Subtracts 1 or 2 from the current index depending on how far the
selected operation is. This fixes going to the wrong page, but
due to it not being a good way of fixing this, it will only be
for the release 2.0 where we won't be adding any more operations.
@samtygier-stfc samtygier-stfc merged commit 63c5b08 into release-2.0.0 Jan 14, 2021
@samtygier-stfc samtygier-stfc deleted the release_fix_wrong_op_help branch January 14, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants