Switch from sarepy to algotom #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might be tricky. Building docs requires importing all the modules in mantidimaging. To get the old doc releases sphinx-multiversion checks out each old release, and builds those docs. So to build the docs we need an environment with that can import all the old versions of mantidimaging. Removing sarepy breaks this. Quick solution is to leave sarepy in the environment. Long term we might need a way to have multiversioned docs without having to rebuild them each time. |
samtygier-stfc
force-pushed
the
1023-algotom
branch
from
ff37c91
to
e8d7f7a
Compare
Replaces sarepy remove_unresponsive_and_fluctuating_stripe
…filtering_sorting These replace sarepy remove_stripe_based_filtering_sorting and remove_stripe_based_2d_filtering_sorting. Note that sort is now an flag argument, rather than a seperate function.
Replaces sarepy remove_stripe_based_sorting_fitting. Note that sort is now an flag argument, rather than a seperate function. Also there is no longer a sigma y option, only sigma with acts on x.
The default has changed, so match old behaviour.
samtygier-stfc
force-pushed
the
1023-algotom
branch
from
1065f63
to
b3d0ba0
Compare
DolicaAkelloEgwel
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1023
Description
The methods in Sarepy have been integrated into Algotom.
Testing & Acceptance Criteria
Docker tests will fail due to new dependency, conda one should pass.
If you create a new dev env
python3 ./setup.py create_dev_envthen tests should pass locally, and stripe removal operations should function
Documentation
Release notes