Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1698: Store processed (but not reconstructed) data in a different place in the nexus file #1734

Merged
merged 12 commits into from
Mar 20, 2023

Conversation

DolicaAkelloEgwel
Copy link
Collaborator

@DolicaAkelloEgwel DolicaAkelloEgwel commented Mar 8, 2023

Issue

Closes #1698

Description

Creates a separate group for processed NeXus data.

Testing

Added test for the NXprocess information and updated existing tests.

Acceptance Criteria

Check that processed data is no longer in the NXTomoproc group.

Documentation

Updated release notes.

@coveralls
Copy link

coveralls commented Mar 9, 2023

Coverage Status

Coverage: 77.23% (+0.02%) from 77.211% when pulling 8200d8f on 1689-store-processed-data into 42a5a13 on main.

@DolicaAkelloEgwel DolicaAkelloEgwel changed the title 1689 store processed data 1698: Store processed (but not reconstructed) data in a different place in the nexus file Mar 9, 2023
@DolicaAkelloEgwel DolicaAkelloEgwel marked this pull request as ready for review March 10, 2023 11:34
Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small changes if you think they make sense.

mantidimaging/core/io/saver.py Show resolved Hide resolved
mantidimaging/core/io/saver.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store processed (but not reconstructed) data in a different place in the nexus file
3 participants