Compute mon norm #2093
Merged
Compute mon norm #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently no test case, because needs additional metadata. |
ashmeigh
force-pushed
the
compute_mon_norm
branch
from
ba36d00
to
0ed71ec
Compare
samtygier-stfc
requested changes
Jun 10, 2024
Comment on lines
19
to
22
| def _divide_by_counts(data=None, counts=None): | ||
| if counts.ndim == 1: | ||
| counts = counts.reshape(1, 1, -1) | ||
| data[:] = np.true_divide(data, counts) |
There was a problem hiding this comment.
This can be removed as its not called any more.
Comment on lines
42
to
43
| # we can't really compute the preview as the image stack copy | ||
| # passed in doesn't have the logfile in it |
There was a problem hiding this comment.
Lets keep this comment
samtygier-stfc
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the ongoing effort to standardize the execution of operations by transitioning from the partial function style to a structured compute_function approach. In this update, several operations have been refactored to adhere to the new standard. The modifications ensure a clearer separation between the setup and execution phases of each operation, improving the maintainability and readability of the codebase.
Changes made
Refactored multiple operations to implement the new compute_function approach.
Introduced static methods compute_function in each affected operation module to encapsulate the core logic for executing the operation on a per-slice basis.
Updated the calling code to use the compute_function method instead of the previous partial function style