FLASH PR - Spectrum Viewer: Export ShutterCount corrected all_norm if ShutterCount correction applied #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t corrected all_norm
JackEAllen
added
the
Release essential
JackEAllen
changed the title
samtygier-stfc
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Not filed as issue
Description
Add a description of the changes made.
Previously if a user exported the spectrum with normalisation applied and ShutterCount correction,
all_normwould export the the normalised spectrum without the ShutterCount correction applied. This PR resolves this issue. the ShutterCount corrected normalised spectrum is not exported if ShutterCount correction has been applied.Testing
Describe the tests that were used to verify your changes.
all_normusing applying only normalisation and normalisation with ShutterCount CorrectionAcceptance Criteria
How should the reviewer test your changes?
all_normcolumn within exported data when exporting with only normalisation and applied against normalisation with ShutterCount correction applied. Also compare against the main branch with normalisation and ShutterCount correction applied which will only export the normalised spectrum forall_normDocumentation
How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes
NA