Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Annotation Enhancement in mantidimaging/core/ Directory part 2 #2284

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

ashmeigh
Copy link
Collaborator

@ashmeigh ashmeigh commented Jul 16, 2024

Issue

Type annotation

Description

Add a description of the changes made.

Testing

Describe the tests that were used to verify your changes.

Acceptance Criteria

How should the reviewer test your changes?

Documentation

How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes

Signed-off-by: ashmeigh <ashleymeigh0@gmail.com>
@coveralls
Copy link

Coverage Status

coverage: 74.316% (+1.2%) from 73.069%
when pulling 2c27547 on Add_Type_core_2
into 45416e7 on main.

Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@samtygier-stfc samtygier-stfc added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit c2f19c2 Aug 7, 2024
7 checks passed
@samtygier-stfc samtygier-stfc deleted the Add_Type_core_2 branch August 7, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants