Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune Docker images between Docker builds #2319

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

MikeSullivan7
Copy link
Collaborator

@MikeSullivan7 MikeSullivan7 commented Aug 15, 2024

Issue

Closes #2313

Description

We now add a pruning step in the Docker Build Github Action, so the Ubuntu Docker is built and published, then deleted such that there is space available to build and push the Rocky8 Docker image.

Acceptance Criteria

Verify that both the Ubuntu and Rocky8 Docker images have built and been pushed successfully here: https://github.com/mantidproject/mantidimaging/actions/runs/10403131433/job/28808990908?pr=2319

Both Docker images should appear here: https://github.com/mantidproject/mantidimaging/pkgs/container/mantidimaging

Documentation

Release note

@MikeSullivan7 MikeSullivan7 added the rebuild_docker 🐋 Add if you want to force rebuild docker images (ONLY IF MERGING INTO MAIN) label Aug 15, 2024
@MikeSullivan7 MikeSullivan7 self-assigned this Aug 15, 2024
@coveralls
Copy link

coveralls commented Aug 15, 2024

Coverage Status

coverage: 74.327%. remained the same
when pulling 2226651 on 2313_Docker_storage_on_github_actions
into 31f6373 on main.

@MikeSullivan7 MikeSullivan7 added rebuild_docker 🐋 Add if you want to force rebuild docker images (ONLY IF MERGING INTO MAIN) and removed rebuild_docker 🐋 Add if you want to force rebuild docker images (ONLY IF MERGING INTO MAIN) labels Aug 15, 2024
@MikeSullivan7 MikeSullivan7 force-pushed the 2313_Docker_storage_on_github_actions branch from 9a21d81 to 725c4fb Compare August 15, 2024 11:29
@MikeSullivan7 MikeSullivan7 added rebuild_docker 🐋 Add if you want to force rebuild docker images (ONLY IF MERGING INTO MAIN) and removed rebuild_docker 🐋 Add if you want to force rebuild docker images (ONLY IF MERGING INTO MAIN) labels Aug 15, 2024
@MikeSullivan7 MikeSullivan7 marked this pull request as ready for review August 15, 2024 11:39
@MikeSullivan7 MikeSullivan7 changed the title 2313 docker storage on GitHub actions Prune Docker images between Docker builds Aug 15, 2024
Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I can see the build suceeded

@samtygier-stfc samtygier-stfc added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit f3c9e9d Aug 16, 2024
6 checks passed
@samtygier-stfc samtygier-stfc deleted the 2313_Docker_storage_on_github_actions branch August 16, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rebuild_docker 🐋 Add if you want to force rebuild docker images (ONLY IF MERGING INTO MAIN)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not enough storage space during Ubuntu and Rocky8 Builds
3 participants