Improve COR and tilt validation in test_correlate and test_minimise
#2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
requested changes
Sep 16, 2024
Comment on lines
62
to
63
| assert final_cor_value != expected_initial_cor | ||
| assert final_tilt_value != expected_initial_tilt |
There was a problem hiding this comment.
Remove the checks that things are different. Check that the initial values are what is expected, I thin 0 and 64.
Comment on lines
65
to
66
| assert final_cor_value == expected_final_cor | ||
| assert final_tilt_value == expected_final_tilt |
There was a problem hiding this comment.
All of the asserts should be self.assertEqual() as that gives better messages.
There was a problem hiding this comment.
Not why, but the PR is trying to delete this file.
ashmeigh
force-pushed
the
2281_test_correlate_check_COR_and_tilt
branch
from
f5a2c81
to
72f463f
Compare
samtygier-stfc
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2281
Description
Updated test_correlate and test_minimise to validate COR and tilt before and after actions. Tests now account for cases where COR doesn't change if it's already optimal while ensuring tilt remains constant.
Testing
Verified both tests, ensuring COR changes appropriately and tilt remains unchanged.
Acceptance Criteria
Run the tests and confirm COR and tilt values are validated correctly, with no failures when COR remains unchanged.