Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close spawned plots on exit #97

Merged
merged 2 commits into from
Sep 22, 2017
Merged

Close spawned plots on exit #97

merged 2 commits into from
Sep 22, 2017

Conversation

DanNixon
Copy link
Member

@DanNixon DanNixon commented Sep 21, 2017 •
edited
Loading

Closes all spawned Matplotlib PyPlot plots when the main window exits.

To test:

  • Load an image
  • Plot it's histogram (Shift+C)
  • Close the main window
  • See that the histogram plot is also closed

Fixes #84

@martyngigg martyngigg self-assigned this Sep 22, 2017
martyngigg
martyngigg approved these changes Sep 22, 2017
View reviewed changes
Copy link
Member

@martyngigg martyngigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as described.

@martyngigg martyngigg merged commit 7568b16 into master Sep 22, 2017
@martyngigg martyngigg deleted the 84_close_plots_on_exit branch September 22, 2017 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martyngigg martyngigg martyngigg approved these changes

Assignees

@martyngigg martyngigg

Labels
Component: GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exiting the main window leaves histograms open
2 participants
@DanNixon @martyngigg