Spacing: fix resolver for empty strings, and strings with spaces

mantinedev · Apr 13, 2024 · 7f6a176 · 7f6a176
1 parent afc9929
commit 7f6a176
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/...mantine/core/src/core/Box/style-props/resolvers/spacing-resolver/spacing-resolver.test.ts b/...mantine/core/src/core/Box/style-props/resolvers/spacing-resolver/spacing-resolver.test.ts
@@ -20,4 +20,9 @@ describe('@mantine/core/Box/spacing-resolver', () => {
     expect(spacingResolver('-10px', DEFAULT_THEME)).toBe(rem(-10));
     expect(spacingResolver('1rem', DEFAULT_THEME)).toBe(rem('1rem'));
   });
+
+  it('resolves empty strings correctly', () => {
+    expect(spacingResolver('', DEFAULT_THEME)).toBe(rem(''));
+    expect(spacingResolver(' 10px', DEFAULT_THEME)).toBe(` ${rem(10)}`);
+  });
 });
diff --git a/packages/@mantine/core/src/core/utils/units-converters/rem.ts b/packages/@mantine/core/src/core/utils/units-converters/rem.ts
@@ -18,6 +18,11 @@ function createConverter(units: string, { shouldScale = false } = {}) {
     }
 
     if (typeof value === 'string') {
+      // Number("") === 0 so exit early
+      if (value === '') {
+        return value;
+      }
+
       if (value.startsWith('calc(') || value.startsWith('clamp(') || value.includes('rgba(')) {
         return value;
       }