Poor performance of closed Popover component onScroll

[yergom]

Dependencies check up

• I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.12.1

What package has an issue?

@mantine/core

What framework do you use?

Vite

In which browsers you can reproduce the issue?

All

Describe the bug

All the components based on Popover (Combobox, Select, Tooltip) re-render too many times when their viewport position changes. As an example, try to profile the following code while scrolling on the ScrollArea:

<ScrollArea h={300}>
    {new Array(100).fill(0).map((_v, idx) => (
      <Select
        key={idx}
        data={["React", "Angular", "Vue", "Svelte"]}
      />
    ))}
</ScrollArea>

The performance problem is not present if, for example, we use keepMounted = false or the Popover is disabled. See attached codesandbox for a comparison

If possible, include a link to a codesandbox with a minimal reproduction

https://codesandbox.io/p/sandbox/mantine-react-template-forked-rtgqx7

Possible fix

After looking at the implementation, I think that the main culprit is

mantine/packages/@mantine/core/src/components/Floating/use-floating-auto-update.ts

Line 19 in 00a94ce

export function useFloatingAutoUpdate({

As long as both refs are there, the effect will run the autoUpdate function. This explains why, when using keepMounted:false, the performance is fixed (because the floating ref is null). The fix is to only call autoUpdate if the floating is open

Self-service

• I would be willing to implement a fix for this issue

[rtivital]

Fixed in 7.13.2