Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineChart withPointLabels: ValueFormatter not applied to point label values #6989

Closed
2 tasks done
me-gusta-v opened this issue Oct 17, 2024 · 1 comment
Closed
2 tasks done
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@me-gusta-v
Copy link

Dependencies check up

  • I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.13.1

What package has an issue?

@mantine/core

What framework do you use?

Vite

In which browsers you can reproduce the issue?

All

Describe the bug

When using "withPointLabels" in the Line/Area/Composite chart, the points are not formatting using the provided valueFormatter.

If possible, include a link to a codesandbox with a minimal reproduction

https://codesandbox.io/p/sandbox/mantine-react-template-forked-r386fh

Possible fix

Pass the valueFormatter to the PointLabel component

Implemented in fork @ a1a8fdc

Self-service

  • I would be willing to implement a fix for this issue
rtivital added a commit that referenced this issue Nov 16, 2024
… LineChant, AreaChart and CompositeChart components (#6989)
@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Nov 16, 2024
@rtivital
Copy link
Member

Fixed in 7.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants