Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover onOpen called on each re-render. #7111

Closed
1 of 2 tasks
crabvk opened this issue Nov 11, 2024 · 5 comments
Closed
1 of 2 tasks

Popover onOpen called on each re-render. #7111

crabvk opened this issue Nov 11, 2024 · 5 comments
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@crabvk
Copy link

crabvk commented Nov 11, 2024

Dependencies check up

  • I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.13.5

What package has an issue?

@mantine/core

What framework do you use?

Vite

In which browsers you can reproduce the issue?

All

Describe the bug

Update component state with Popover opened, onOpen triggered on each re-render.
Expected onOpen to be called only once when I open Popover (as it works now) and nothing on re-renders (the bug).

If possible, include a link to a codesandbox with a minimal reproduction

https://codesandbox.io/p/sandbox/mantine-popover-bug-forked-8446wc

Possible fix

No response

Self-service

  • I would be willing to implement a fix for this issue
@rtivital
Copy link
Member

Your sandbox is private, I cannot access it, please make it public.

@crabvk
Copy link
Author

crabvk commented Nov 11, 2024

Should be accessible now.

@ndelon
Copy link

ndelon commented Nov 11, 2024

I reported a similar issue on the Combobox component few weeks ago: #7022 .

@maxiadlovskii
Copy link

I created another issue #7115 I think they might have the same root

rtivital added a commit that referenced this issue Nov 16, 2024
@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Nov 16, 2024
@rtivital
Copy link
Member

Fixed in 7.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

4 participants