Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/tagsinput duplicate deletion #6922

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Fix/tagsinput duplicate deletion #6922

merged 4 commits into from
Oct 2, 2024

Conversation

ctdunc
Copy link
Contributor

@ctdunc ctdunc commented Sep 30, 2024

This had bad behavior in the last PR that I've fixed here. Apologies!

@rtivital
Copy link
Member

toSpliced method does not fit into browser support.

  1. https://caniuse.com/mdn-javascript_builtins_array_tospliced
  2. https://mantine.dev/about/#browser-support

@rtivital
Copy link
Member

rtivital commented Oct 1, 2024 •
edited
Loading

Have you validated that it works correctly this time is Storybook?

@rtivital rtivital merged commit b12a152 into mantinedev:master Oct 2, 2024
1 check passed
@rtivital
Copy link
Member

rtivital commented Oct 2, 2024

Thanks!

@dxanh97 dxanh97 mentioned this pull request Oct 3, 2024
Closed
2 tasks
@ctdunc ctdunc mentioned this pull request Oct 24, 2024
Closed
@sam-morin sam-morin mentioned this pull request Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctdunc @rtivital