Implement withRunningKafkaOnFoundPort #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manub
requested changes
Jun 25, 2017
| consumeFirstStringMessageFrom("topic")(actualConfig2) shouldBe "message2" | ||
| val allConfigs = Seq(userDefinedConfig, actualConfig1, actualConfig2) | ||
| // Confirm both actual configs are running on separate non-zero ports, but otherwise equal | ||
| allConfigs.map(_.kafkaPort).distinct.size shouldBe 3 |
There was a problem hiding this comment.
can you please use .distinct should have size 3? here and wherever you use to check sizes
mikemintz
force-pushed
the
run-kafka-on-available-port
branch
3 times, most recently
from
d92d200 to
6f82e90
Compare
This is useful for writing tests that configure kafka/zookeeper to listen on port 0, i.e. listen on an arbitrary available port.
mikemintz
force-pushed
the
run-kafka-on-available-port
branch
from
6f82e90 to
3508fe0
Compare
|
Thanks for reviewing this. I updated the README and test syntax, let me know if there's anything else I should change. |
manub
approved these changes
Jun 27, 2017
|
Thanks! Releasing tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
withRunningKafkaOnFoundPort, which allows users to run zookeeper/kafka on arbitrary available ports instead of having to hard-code specific ports. This is useful to make tests more reliable, especially when running tests in parallel or on machines where other tests or services may be running with port numbers you can't control.I'm happy to refactor this however you like. It might be cleaner to just change the implementation of
withRunningKafkato takebody: EmbeddedKafkaConfig => Tinstead ofbody: => T, since that only requires a single implementation. But that breaks backwards compatibility, so I didn't go that direction for now.