-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize variables stored during CI builds #130
Comments
I will work on the implementation of this
Currently, {% if ci_source is defined -%}
([permalink](https://{{ci_source.repo_owner}}.github.io/{{ci_source.repo_name}}/v/{{ci_source.commit}}/))
{% endif -%} So do we want to omit the permalink altogether for AppVeyor builds or do we want to give the artifact link? |
I hadn't thought about giving the artifact link. I like that idea. The artifacts aren't permanent though, so it would be a slight abuse of terminology to call it a permalink (even though AppVeyor does in their webhook doc). I'm also okay discarding the link completely if that's easier. Or adding a new |
Temporary, for help with manubot/manubot#130
Currently, Manubot stores the repository and commit metadata when it is run on Travis CI:
manubot/manubot/process/util.py
Lines 189 to 199 in 66c1c87
Per manubot/rootstock#198 (comment) we would like to generalize this to store similar metadata for other continuous integration services. AppVeyor is of immediate interest because it will be used for pull request build previews in manubot/rootstock#262.
AppVeyor's environment variables are listed at https://www.appveyor.com/docs/environment-variables/. We likely want:
APPVEYOR
APPVEYOR_PROJECT_SLUG
APPVEYOR_REPO_COMMIT
We could also store which CI service was used in a new variable. When updating
manubot/rootstock
, we'll also need to update the front matter permalink, which is only relevant for Travis CI.The text was updated successfully, but these errors were encountered: