AppVeyor not building PDF

[olgabot]

Hello,
I'm not able to build the intermediate PDF of the manuscript which hinders my ability to solicit feedback on intermediate work. In this PR: https://github.com/czbiohub/orthology-free-comparative-transcriptomics-paper/pull/47 the AppVeyor build works at first, but then for some reason stops accepting events:

I don't understand why skip_branch_with_pr: true is set in the appveyor.yml file, since don't we want to build the pdfs for PRs?

Let me know if there is anything else I can provide!
Warmest,
Olga

[dhimmel]

Traveling back from Africa, will take a look on Friday.

[agitter]

I can help troubleshoot this in https://github.com/czbiohub/orthology-free-comparative-transcriptomics-paper/pull/47

[dhimmel]

As @agitter diagnosed in https://github.com/czbiohub/orthology-free-comparative-transcriptomics-paper/pull/47#issuecomment-585748162, the issue is due to the pull request having a merge conflict:

AppVeyor (and other CI services) evaluate a merge commit for pull requests rather than the actual commit on the PR branch. Therefore when there is a conflict, they cannot proceed with CI.

Changing to skip_branch_with_pr: false would probably not have an effect because we are specifying only master branch builds anyways:

rootstock/.appveyor.yml

Lines 1 to 8 in 40b0e5b

	# See https://www.appveyor.com/docs/getting-started-with-appveyor-for-linux/
	skip_branch_with_pr: true
	# Enable 'Do not build on "Push" events' in the AppVeyor project settings
	# to only build commits from pull requests
	branches:
	only:
	- master

But if you remove everything quoted above, then you would be able to build the push event for your branch. Once the merge conflict was resolved, you'd then get two CI jobs for each PR commit (one for the branch push event and another of the pull request event).

[olgabot]

Ohh I see! Now I understand. Would it be possible to add an error message from AppVeyor that he PDF wasn't built because of the merge conflict? I wouldn't have thought to fix that without your help. Thank you so much!

[olgabot]

YAYY IT BUILT!!!! THANK YOU SO MUCH!!! https://github.com/czbiohub/orthology-free-comparative-transcriptomics-paper/pull/47/#issuecomment-586493091

🎉🎉🎉🎉🎉🎉🎉🎉🎉

[agitter]

The merge conflict prevents AppVeyor from running at all, so I don't think we have control over the AppVeyor notifications to point out the merge conflict caused the problem. I first noticed this in https://github.com/czbiohub/de-novo-orthology-paper/pull/47 because in the commit showed a failed build

Perhaps this points to a place where we could improve documenation.