Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to version artifacts #305

Merged
merged 7 commits into from
Jan 29, 2020
Merged

Conversation

dhimmel
Copy link
Member

@dhimmel dhimmel commented Jan 28, 2020

@dhimmel
Copy link
Member Author

dhimmel commented Jan 28, 2020

@olgabot, this PR will enable the artifacts archive to be named something like output-121907e. We could create any name we want like: 2020-01-28-manubot-ci-output-121907e. @agitter @olgabot, any preferences?

@agitter
Copy link
Member

agitter commented Jan 28, 2020

I'd say the commit hash is the most essential part of the filename. The datestamp alone is ambiguous when multiple builds are run in the same day, and a build or job id is not as easy to map back to the source modifications for that build.

Beyond that, I don't have strong opinions. 2020-01-28-manubot-ci-output-121907e is a little long but works for me. output-121907e is also good.

I'm glad to see that someone else likes these AppVeyor notifications :)

@dhimmel
Copy link
Member Author

dhimmel commented Jan 29, 2020

What about manuscript-$GITHUB_ACTION-$COMMIT like manuscript-413593601-121907e?

Things I'd like in the name:

  1. sorts chronologically
  2. sorts such that all other manubot output archives are adjacent in a cluttered Downloads folder
  3. easy to associate output with commit that triggered it and the action that created it
  4. recognizable as a manubot manuscript in a Downloads folder where it's been forgotten about.

@dhimmel dhimmel merged commit 713000d into manubot:master Jan 29, 2020
@dhimmel dhimmel deleted the version-artifacts branch January 29, 2020 15:45
@agitter
Copy link
Member

agitter commented Jan 29, 2020

Things I'd like in the name:

Those are all great properties. I like the scheme you went with.

ploegieku added a commit to ploegieku/2023-functional-homology-paper that referenced this pull request Aug 6, 2024
merges manubot/rootstock#305

Create artifacts that are named like manuscript-32632624-d1c4caf
and contain the GitHub Actions run-id as well as the head of the triggering
commit hash. Note that on a pull request, this is the commit that was
added to the PR and not the auto-generated merge commit that the
action is actually evaluating.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants