-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to version artifacts #305
Conversation
f2f4888
to
71dca3e
Compare
bf890fe
to
121907e
Compare
I'd say the commit hash is the most essential part of the filename. The datestamp alone is ambiguous when multiple builds are run in the same day, and a build or job id is not as easy to map back to the source modifications for that build. Beyond that, I don't have strong opinions. I'm glad to see that someone else likes these AppVeyor notifications :) |
What about Things I'd like in the name:
|
Those are all great properties. I like the scheme you went with. |
merges manubot/rootstock#305 Create artifacts that are named like manuscript-32632624-d1c4caf and contain the GitHub Actions run-id as well as the head of the triggering commit hash. Note that on a pull request, this is the commit that was added to the PR and not the auto-generated merge commit that the action is actually evaluating.
look into addressing https://github.com/czbiohub/orthology-free-comparative-transcriptomics-paper/pull/41#issuecomment-579419055