Introduce a checkcast instruction to placate java verifier #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recent updates to the jvm verifier have made it stricter than before, requiring the addition of (checkcast pair) in main before calling bigloo_main.
The compiler treats the class type of Object and is expect foreign to
implement BGL_AS_CLASS as:
Object BGL_AS_CLASS(Object o)
not:
bclass BGL_AS_CLASS(Object o)
Without this correction, the jvm complains that it cannot find
BGL_AS_CLASS.
|
Interesting. We are currently working on a wasm backend and we noticed that some type casts were missing and some that some expressions were not correctly typed. Fixing those might have trigger the new JVM errors. Anyway, thanks for the fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recent updates to the jvm verifier have made it stricter than before, requiring the addition of (checkcast pair) in main before calling bigloo_main.