Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature share chat room #11

Merged

Conversation

iamvishal345
Copy link
Collaborator

  1. Add Share button and Share dropdown to share the Chat Room.
  2. Update Join component to parse the Query string and set room text field on load.
  3. Fixed a typo in chat component.

@vercel
Copy link

vercel bot commented Oct 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chatcus – ./client

🔍 Inspect: https://vercel.com/manuelalferez/chatcus/251N7sVTh8jgGPubCDb7bCmH1str
✅ Preview: https://chatcus-git-fork-iamvishal345-feature-shar-420469-manuelalferez.vercel.app

chat – ./client

🔍 Inspect: https://vercel.com/manuelalferez/chat/3eqoJjJtSTKGqdC4cC8GCfhRfgS8
✅ Preview: https://chat-git-fork-iamvishal345-feature-sharechatroom-manuelalferez.vercel.app

Copy link
Owner

@manuelalferez manuelalferez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the feature Vishal ❤️

Running the app locally, I found some bugs with the links:

  • Share to LinkedIn

Captura de pantalla 2021-10-07 a las 8 47 19

  • Share to Facebook

Captura de pantalla 2021-10-07 a las 8 47 30

  • Share Post via... doesn't work

Captura de pantalla 2021-10-07 a las 8 47 46

Another bug is that the sharing menu never disappears. Not even when you click outside of it.

Amazing feature man!

@iamvishal345
Copy link
Collaborator Author

iamvishal345 commented Oct 7, 2021

@manuelalferez For local it will not work due to http security issues.
Will start working on fix of sharing menu never disappears.
Share Post Via.. is using browsers navigator API So it will work on supported platforms. I added it mainly to open share popup in Android and Ios Browsers.

@iamvishal345
Copy link
Collaborator Author

@manuelalferez Updated PR for fix of sharing menu never disappears.

@manuelalferez
Copy link
Owner

Awesome work @iamvishal345 🔝
Thank you for that new feature ❤️

@manuelalferez manuelalferez merged commit f507400 into manuelalferez:master Oct 7, 2021
@iamvishal345 iamvishal345 linked an issue Oct 8, 2021 that may be closed by this pull request
@iamvishal345 iamvishal345 deleted the feature-shareChatRoom branch October 22, 2021 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI refinements in chat room
2 participants