Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create reactjs to vite and tailwindcss config #15

Closed
wants to merge 6 commits into from

Conversation

chalermporn
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Oct 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chat – ./client

🔍 Inspect: https://vercel.com/manuelalferez/chat/5S3xvGWagxFiXB6FV1oZ9CMs6dQj
✅ Preview: https://chat-git-fork-chalermporn-master-manuelalferez.vercel.app

chatcus – ./client

🔍 Inspect: https://vercel.com/manuelalferez/chatcus/EN1LCLhuJpxawxzLWycnFdXjuyZN
✅ Preview: Failed

[Deployment for a0a70c3 failed]

@manuelalferez
Copy link
Owner

Hi @chalermporn,
Could you explain a little bit about the changes you have made and why?
Also I noticed that you use another code formatter. Please use Prettier in order to have a consistent code style.

@iamvishal345
Copy link
Collaborator

iamvishal345 commented Oct 8, 2021

@manuelalferez I think using vite instead of webpack will improve the dev server start time. Why Vite..
But It has some different way to import images and creating build so we have to make sure everything works as expected before deploying it.

@manuelalferez
Copy link
Owner

manuelalferez commented Oct 8, 2021

Forgive my ignorance, this is the first time I know about Vite. What little I have read I really liked!

I am going to list some of the readings that helped me to have a better image of Vite:

If you have any reading that you recommend @chalermporn and @iamvishal345, I will be happy to read them 😊

@iamvishal345 I have added you to review this pull request, if you don't want to take that responsibility, let me know.

Go ahead with Vite guys!

@iamvishal345
Copy link
Collaborator

@chalermporn I took a pull and ran it locally. It is working fine. Please resolve the merge conflicts and update the PR.
@manuelalferez Is it possible for you to check why this build for client is failing.

@chalermporn
Copy link
Contributor Author

close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants