-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added icons to share options list and added an alert box for sign in #23
Conversation
This pull request is being automatically deployed with Vercel (learn more). chatcus – ./client🔍 Inspect: https://vercel.com/manuelalferez/chatcus/92hcFPLXyiyhGfaSW3ckv54EjX1p [Deployment for b5ad308 failed] chat – ./client🔍 Inspect: https://vercel.com/manuelalferez/chat/2Zf2NMc1FfCKLfTtHyix7TcUNesB [Deployment for b5ad308 failed] |
Fixes #24 |
d288065
to
951aafe
Compare
@kritikash18 , This is good UI change. I have some suggestions for this change
Regarding alert box, this is also great. |
@manuelalferez @iamvishal345 I updated the icons to SVG and center aligned the content. After alignment, which one of the following do you think looks better? |
@kritikash18 I think vertical align is fine. Keep horizontal align as space between. |
I see everything perfect. Thanks @kritikash18 for the new feature and @iamvishal345 for the review. |
Updated it with icons for each option, so it looks like this: