-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the SeePassword in the page.tsx file #126
base: main
Are you sure you want to change the base?
Conversation
@Suvendu-UI is attempting to deploy a commit to the manuelalferez's projects Team on Vercel. A member of the Team first needs to authorize it. |
Hey @manuelalferez new pr pls review this |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Why is the view password button outside the password input? It is good practice to have the components and their most direct functionality as close to each other as possible. Example: Flowinance-PasswordInput.mp4This page of components are very good, and they already do the work for you: |
can u give the file name where the password input is there, bcoz i think that it is in the .gitignore file |
@Suvendu-UI I don't think I understand what you are trying to say or ask. please can you rephrase? I really want to understand you |
it would be nice if you could tell me the file where this part's code is |
made the changes just the code the place where there is the input of password of email then we are set to go |
Hi @Suvendu-UI, the show button is outside the component. It should not be there, it should be inside the password input. Can you move it there? Expected behavior: Flowinance-PasswordInput.mp4 |
I know this but I couldn't get the place where the location of that file having the input for password and email is there, can you give the location of the file ? |
Pull Request Template
How
Explain how you implemented the changes. Include any relevant information that would help reviewers understand your approach.
I added seePassword function which changes the type in input from "text" to "password" using onClick