Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the SeePassword in the page.tsx file #126

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Suvendu-UI
Copy link

Pull Request Template

How

Explain how you implemented the changes. Include any relevant information that would help reviewers understand your approach.

I added seePassword function which changes the type in input from "text" to "password" using onClick

Copy link

vercel bot commented Oct 17, 2024

@Suvendu-UI is attempting to deploy a commit to the manuelalferez's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Suvendu-UI
Copy link
Author

Hey @manuelalferez new pr pls review this

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowinance ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 10:00am

@manuelalferez
Copy link
Owner

Why is the view password button outside the password input?

image

It is good practice to have the components and their most direct functionality as close to each other as possible. Example:

Flowinance-PasswordInput.mp4

This page of components are very good, and they already do the work for you:
https://originui.com/inputs

@Suvendu-UI
Copy link
Author

can u give the file name where the password input is there, bcoz i think that it is in the .gitignore file

@manuelalferez
Copy link
Owner

@Suvendu-UI I don't think I understand what you are trying to say or ask. please can you rephrase? I really want to understand you

@Suvendu-UI
Copy link
Author

i can't get the .tsx file for this part so that i can put the button
Screenshot 2024-10-18 211357

@Suvendu-UI
Copy link
Author

it would be nice if you could tell me the file where this part's code is

@Suvendu-UI
Copy link
Author

made the changes just the code the place where there is the input of password of email then we are set to go

@manuelalferez
Copy link
Owner

manuelalferez commented Oct 22, 2024

Hi @Suvendu-UI, the show button is outside the component. It should not be there, it should be inside the password input. Can you move it there?
image

Expected behavior:

Flowinance-PasswordInput.mp4

@Suvendu-UI
Copy link
Author

I know this but I couldn't get the place where the location of that file having the input for password and email is there, can you give the location of the file ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants