Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2.0: Support packages.config and exclude the attributes from code coverage by default #7

Merged
merged 7 commits into from
Dec 24, 2019

Conversation

manuelroemer
Copy link
Owner

v1.2.0

This release provides solutions for issue #1 and
issue #6. In addition, potential compiler
warnings in the NullableAttributes.cs file are now hidden.

Upgrading:

Remove any previously defined NULLABLE_ATTRIBUTES_EXCLUDE_FROM_CODE_COVERAGE compiler constant,
as it does not have any effect anymore.

ℹ️ Note:

Builds will NOT break if the constant is still defined. It is simply ignored now.

Details:

  • The package now supports packages.config via a content/ folder in the NuGet package.
  • The attributes are now excluded from code coverage by default.
    When referenced from projects targeting .NET Standard >= 2.0 or .NET Framework >= 4.0, the
    ExcludeFromCodeCoverageAttribute is used. For other project types, the DebuggerNonUserCodeAttribute
    is used.
  • Added support for the NULLABLE_ATTRIBUTES_INCLUDE_IN_CODE_COVERAGE compiler constant which
    removes the code coverage attributes.
  • The NULLABLE_ATTRIBUTES_EXCLUDE_FROM_CODE_COVERAGE compiler constant no longer has
    any effects. Code coverage is now disabled by default.
  • The NullableAttributes.cs file now wraps the attributes with a #pragma warning disable and
    #pragma warning restore block to disable both compiler- and code-analysis warnings.

@manuelroemer manuelroemer merged commit 8fd42d4 into master Dec 24, 2019
@manuelroemer manuelroemer deleted the v1_20 branch December 24, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant