Ticket 44 errors should raise exceptions #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 21, 2015 10:31
Added URLError exception to __init__.py which is raised when an invalid URL is sent to functions. IOError raised when file does not exist.
The removed code block is called in `find_proxy` there is no need to duplicate the code.
mattseymour
force-pushed
the
ticket-44--errors-should-raise-exceptions
branch
from
c0af81b to
f4dfd04
Compare
|
Thank you, Matt! |
manugarg
added a commit
that referenced
this pull request
Aug 21, 2015
…e-exceptions Ticket 44 errors should raise exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions should return Exceptions not print messages and None see ticket #44 for more information.