Google backporting #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As downloaded from http://ftp.mozilla.org/pub/mozilla.org/js/js-1.8.0-rc1.tar.gz Signed-off-by: Stefano Lattarini <slattarini@google.com>
This is part of the backporting of Google-specific modifications to upstream pacparser. Notice that the tests do not pass yet for the pactester build from the git repository, but works from the one built from the Google-modified version. My plan is to use the enhanced test to do the backporting in a "test-driven" way. Signed-off-by: Stefano Lattarini <slattarini@google.com>
Still unused, but will be later properly plumbed in as part of the backport of Google-specific modifications. Signed-off-by: Stefano Lattarini <slattarini@google.com>
To enhance readability, reduce code duplication, and pave the road for upcoming backporting of Google-specific features. Signed-off-by: Stefano Lattarini <slattarini@google.com>
That was the documented behavior, but the actual one was to return the empty string -- which is also inconsistent with the myIpAddress() behavior, which already returned return 127.0.0.1 if not able to determine the local IP. Signed-off-by: Stefano Lattarini <slattarini@google.com>
Same as dnsResolve(); which will allow us to reduce code duplication Signed-off-by: Stefano Lattarini <slattarini@google.com>
For less strcpy and more sanity in the callers Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
But keep them enabled by default. Signed-off-by: Stefano Lattarini <slattarini@google.com>
…tions - support bracketed IPv6 addresses in URLs (rather than choking on them) - everything requiring interactions with actual DNS via c-ares is still dummied-out - snatch the occasion to be more respectful of Google's coding standards for shell scripts in our shell-based tests Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
That is, once we actually have c-ares integration, they should do so when the c-ares library is not available at build time. So prepare the existing code to handle such failures. While at it, slightly improve some existing error messages. Signed-off-by: Stefano Lattarini <slattarini@google.com>
Arguments to exported functions are already documented in the javadoc-style comments preceding each declaration. And where they are not, make them so. Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Also update LGPLv3 notice from the latest version at <http://www.gnu.org/licenses/gpl-howto.html> Signed-off-by: Stefano Lattarini <slattarini@google.com>
Some stylistic and buglets fixes while at it. Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
…queries() Just to avoid conflicts with the slightly-modified Google's c-ares library. Fix a couple of typofixes while at it. Signed-off-by: Stefano Lattarini <slattarini@google.com>
Adding a new one admittedly; but I plan to use it to replace other more complex ones as well... Signed-off-by: Stefano Lattarini <slattarini@google.com>
Reducing potential memory leaks and diffs with pacparser_resolve_host_ares() Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Also remove SYMBOL_CACHE_SIZE from doxygen.config, as doxygen says it has become obsolete. And remove trailing whitespace from doxygen.config. Signed-off-by: Stefano Lattarini <slattarini@google.com>
…ils) For a simplified Makefile and a saner python testing. Start adding python tests based on PyUnit. More will follow. Signed-off-by: Stefano Lattarini <slattarini@google.com>
…function once We never prevented that to have collateral effects (e.g., aborting the program), so we cannot assume it will just return after each call. Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
…emory leaks On failure, realloc returns NULL. So imagine this scenario: realloc succeeds the first time, foo is allocated; then it fails the second time, returns NULL, pointer to originally allocated foo is lost: we have a memory leak. Thanks qdii@google.com for highlighting this. Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
…d in case of a setup error Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Following a suggestion from qdii@google.com Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
…fo() errors errno is only set if the return value of getnameinfo() is EAI_SYSTEM Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
…artial (as mangled by our processing involving pointer arithmetic) Signed-off-by: Stefano Lattarini <slattarini@google.com>
…s during setup Signed-off-by: Stefano Lattarini <slattarini@google.com>
…y != 0 Signed-off-by: Stefano Lattarini <slattarini@google.com>
Some small refactorings while at it. Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
Signed-off-by: Stefano Lattarini <slattarini@google.com>
|
Changes in this PR are humongous and obviously old. It will be hard to merge it, but there some very useful and interesting tidbits here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport refactorings, enhancements (especially in tests) and c-ares integration implemented in the Google fork of pacparser.