don't discard errors, just don't retry performance jobs

manyfold3d · Jun 27, 2024 · b7db937 · b7db937
1 parent 46229f3
commit b7db937
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/app/jobs/analysis/file_conversion_job.rb b/app/jobs/analysis/file_conversion_job.rb
@@ -8,9 +8,8 @@ class NonManifoldError < StandardError
 
 class Analysis::FileConversionJob < ApplicationJob
   queue_as :performance
+  sidekiq_options retry: false
 
-  discard_on UnsupportedFormatError
-  discard_on NonManifoldError
 
   def perform(file_id, output_format)
     # Can we output this format?

diff --git a/app/jobs/analysis/geometric_analysis_job.rb b/app/jobs/analysis/geometric_analysis_job.rb
@@ -3,7 +3,7 @@ class MeshLoadError < StandardError
 
 class Analysis::GeometricAnalysisJob < ApplicationJob
   queue_as :performance
-  discard_on MeshLoadError
+  sidekiq_options retry: false
 
   def perform(file_id)
     # Get model