Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploaded models get created as root #1704

Closed
Floppy opened this issue Dec 21, 2023 · 3 comments · Fixed by #2253
Closed

Uploaded models get created as root #1704

Floppy opened this issue Dec 21, 2023 · 3 comments · Fixed by #2253
Labels
bug Something isn't working security

Comments

@Floppy
Copy link
Collaborator

Floppy commented Dec 21, 2023

When uploading models, the created folders and files have root.root user and group ownership. This is somewhat disturbing, as the app itself should be running using the UID and PID specified in the Dockerfile, so why is it happening?

EDIT: The UID and PID aren't actually set in the Dockerfile. I thought they were.

@Floppy Floppy added the bug Something isn't working label Dec 21, 2023
@Rukongai Rukongai mentioned this issue Feb 17, 2024
7 tasks
@prosthetichead
Copy link

I'm having this issue with all the files and folders created by manyfold being owned by root/root. I can not find anything on how to fix this but noticed on the linked pull request the user should be running as 1000:1000? it seems its not?

@Floppy
Copy link
Collaborator Author

Floppy commented Apr 14, 2024

Yeah, that PR isn't in yet. At the moment it's using whatever the docker user is. Which is bad. I'm looking at doing a security audit soon so I'll have to resolve this one before that.

@Floppy Floppy mentioned this issue Apr 21, 2024
4 tasks
@Floppy
Copy link
Collaborator Author

Floppy commented Jun 10, 2024

Linking #2240 to track the root cause (no pun intended).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants