Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PUID and PGID env vars to control which user the app runs as #2253

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

Floppy
Copy link
Collaborator

@Floppy Floppy commented Jun 12, 2024

We've added s6-overlay, a common toolset for containers, in order to be able to use s6-setuidgid to dynamically reduce permission on the running app. If users now set PUID and PGID in their docker configurations, just like a lot of other apps (e.g. linuxserver/*), that user will be the one the app runs as.

Resolves #2240
Resolves #1704

@Floppy Floppy added feature User-facing features and product enhancements security labels Jun 12, 2024
@Floppy Floppy enabled auto-merge June 12, 2024 15:40
Copy link

codeclimate bot commented Jun 12, 2024

Code Climate has analyzed commit 04ff809 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.7% (0.0% change).

View more on Code Climate.

@Floppy Floppy merged commit 5ea7836 into main Jun 12, 2024
10 checks passed
@Floppy Floppy deleted the maf-003-s6-overlay branch June 12, 2024 15:43
@Floppy
Copy link
Collaborator Author

Floppy commented Jun 13, 2024

Confirmed working on local install. Lovely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature User-facing features and product enhancements security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAF-003: [MODERATE] Docker container runs as root Uploaded models get created as root
1 participant