Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloaded models have wrong disposition, so open in browser #2631

Closed
Floppy opened this issue Sep 5, 2024 · 0 comments · Fixed by #2634
Closed

Downloaded models have wrong disposition, so open in browser #2631

Floppy opened this issue Sep 5, 2024 · 0 comments · Fixed by #2634
Labels
bug Something isn't working funded We've got money earmarked for this work
Milestone
v1.0.0

Comments

@Floppy
Copy link
Collaborator

Floppy commented Sep 5, 2024

When downloading ASCII files (STL, OBJ, etc) they open in the browser instead of saving. Disposition is wrong, and we should add a download query parameter to ModelFileController#get so that we can make it right.
@Floppy Floppy added bug Something isn't working funded We've got money earmarked for this work labels Sep 5, 2024
@Floppy Floppy added this to the v1.0.0 milestone Sep 5, 2024
@Floppy Floppy mentioned this issue Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working funded We've got money earmarked for this work
Projects
Manyfold Development
Status: Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Fix download behaviour for ASCII files manyfold3d/manyfold
1 participant
@Floppy