Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download behaviour for ASCII files #2634

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Fix download behaviour for ASCII files #2634

merged 1 commit into from
Sep 6, 2024

Conversation

Floppy
Copy link
Collaborator

@Floppy Floppy commented Sep 6, 2024

resolves #2631

@Floppy Floppy added the bug Something isn't working label Sep 6, 2024
Copy link

codeclimate bot commented Sep 6, 2024

Code Climate has analyzed commit 3fb5a9c and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.8% (0.0% change).

View more on Code Climate.

@Floppy Floppy merged commit 28abcb2 into main Sep 6, 2024
11 checks passed
@Floppy Floppy deleted the fix-disposition branch September 6, 2024 09:34
truecharts-admin added a commit to truecharts/charts that referenced this pull request Sep 10, 2024
….78.0@332ca1c by renovate (#26210)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/manyfold3d/manyfold](https://redirect.github.com/manyfold3d/manyfold)
| minor | `0.77.3` -> `0.78.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>manyfold3d/manyfold (ghcr.io/manyfold3d/manyfold)</summary>

###
[`v0.78.0`](https://redirect.github.com/manyfold3d/manyfold/releases/tag/v0.78.0)

[Compare
Source](https://redirect.github.com/manyfold3d/manyfold/compare/v0.77.3...v0.78.0)

Now you can set a creator, collection, license and tags straight away at
upload time! That'll make things a bit easier...

#### What's Changed

##### ✨ New Features ✨

- Set creator/collection/license/tags during upload by
[@&#8203;Floppy](https://redirect.github.com/Floppy) in
[manyfold3d/manyfold#2637

##### 🐛 Bug Fixes 🐛

- Calculate tag list before model pagination is applied by
[@&#8203;Floppy](https://redirect.github.com/Floppy) in
[manyfold3d/manyfold#2633
- Fix download behaviour for ASCII files by
[@&#8203;Floppy](https://redirect.github.com/Floppy) in
[manyfold3d/manyfold#2634
- Make sure new tags are used in paths in bulk edit organize by
[@&#8203;Floppy](https://redirect.github.com/Floppy) in
[manyfold3d/manyfold#2638
- Fix incorrect DISTINCT queries by
[@&#8203;Floppy](https://redirect.github.com/Floppy) in
[manyfold3d/manyfold#2642
- Fix tags not being removed in bulk editor by
[@&#8203;Floppy](https://redirect.github.com/Floppy) in
[manyfold3d/manyfold#2653
- Move activity backfill to after permission-related DB changes by
[@&#8203;Floppy](https://redirect.github.com/Floppy) in
[manyfold3d/manyfold#2659
- Sweep up old cache files every hour by
[@&#8203;Floppy](https://redirect.github.com/Floppy) in
[manyfold3d/manyfold#2660
- Improve error visibility for failed uploads by
[@&#8203;Floppy](https://redirect.github.com/Floppy) in
[manyfold3d/manyfold#2664
- Make archive extraction thread-safe by
[@&#8203;Floppy](https://redirect.github.com/Floppy) in
[manyfold3d/manyfold#2665
- Fix changing presupported state causing database inconsistency by
[@&#8203;Floppy](https://redirect.github.com/Floppy) in
[manyfold3d/manyfold#2666

##### 🛠️ Other Improvements 🛠️

- Update to Ruby 3.3.5 by
[@&#8203;Floppy](https://redirect.github.com/Floppy) in
[manyfold3d/manyfold#2641

**Full Changelog**:
manyfold3d/manyfold@v0.77.3...v0.78.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4wIiwidXBkYXRlZEluVmVyIjoiMzguNzQuMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJhdXRvbWVyZ2UiLCJ1cGRhdGUvZG9ja2VyL2dlbmVyYWwvbm9uLW1ham9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Downloaded models have wrong disposition, so open in browser
1 participant