Set creator/collection/license/tags during upload #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 1aa0a12 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 90.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 86.8% (0.0% change). View more on Code Climate. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -1,21 +1,27 @@ | |||
| class ProcessUploadedFileJob < ApplicationJob | |||
| queue_as :default | |||
|
|
|||
| def perform(library_id, uploaded_file, owner: nil) | |||
| def perform(library_id, uploaded_file, owner: nil, creator_id: nil, collection_id: nil, tags: nil, license: nil) | |||
There was a problem hiding this comment.
Method perform has 31 lines of code (exceeds 25 allowed). Consider refactoring.
truecharts-admin
referenced
this pull request
in truecharts/public
Sep 10, 2024
….78.0@332ca1c by renovate (#26210) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/manyfold3d/manyfold](https://redirect.github.com/manyfold3d/manyfold) | minor | `0.77.3` -> `0.78.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>manyfold3d/manyfold (ghcr.io/manyfold3d/manyfold)</summary> ### [`v0.78.0`](https://redirect.github.com/manyfold3d/manyfold/releases/tag/v0.78.0) [Compare Source](https://redirect.github.com/manyfold3d/manyfold/compare/v0.77.3...v0.78.0) Now you can set a creator, collection, license and tags straight away at upload time! That'll make things a bit easier... #### What's Changed ##### ✨ New Features ✨ - Set creator/collection/license/tags during upload by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2637](https://redirect.github.com/manyfold3d/manyfold/pull/2637) ##### 🐛 Bug Fixes 🐛 - Calculate tag list before model pagination is applied by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2633](https://redirect.github.com/manyfold3d/manyfold/pull/2633) - Fix download behaviour for ASCII files by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2634](https://redirect.github.com/manyfold3d/manyfold/pull/2634) - Make sure new tags are used in paths in bulk edit organize by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2638](https://redirect.github.com/manyfold3d/manyfold/pull/2638) - Fix incorrect DISTINCT queries by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2642](https://redirect.github.com/manyfold3d/manyfold/pull/2642) - Fix tags not being removed in bulk editor by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2653](https://redirect.github.com/manyfold3d/manyfold/pull/2653) - Move activity backfill to after permission-related DB changes by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2659](https://redirect.github.com/manyfold3d/manyfold/pull/2659) - Sweep up old cache files every hour by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2660](https://redirect.github.com/manyfold3d/manyfold/pull/2660) - Improve error visibility for failed uploads by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2664](https://redirect.github.com/manyfold3d/manyfold/pull/2664) - Make archive extraction thread-safe by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2665](https://redirect.github.com/manyfold3d/manyfold/pull/2665) - Fix changing presupported state causing database inconsistency by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2666](https://redirect.github.com/manyfold3d/manyfold/pull/2666) ##### 🛠️ Other Improvements 🛠️ - Update to Ruby 3.3.5 by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2641](https://redirect.github.com/manyfold3d/manyfold/pull/2641) **Full Changelog**: manyfold3d/manyfold@v0.77.3...v0.78.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4wIiwidXBkYXRlZEluVmVyIjoiMzguNzQuMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJhdXRvbWVyZ2UiLCJ1cGRhdGUvZG9ja2VyL2dlbmVyYWwvbm9uLW1ham9yIl19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2382