Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding app version as an attribute #2194

Merged
merged 10 commits into from
May 28, 2024

Conversation

matthewbadeau
Copy link
Contributor

Checklist

🚨 Please review the guidelines for contributing to this repository. 🚨

  • Make sure you are making a pull request against our main branch (left side)
  • Check that that your branch is up to date with our main.
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Check that the tests and code linter both pass.
  • If you're a new contributor, please sign our contributor license agreement.

Warnings

  • This PR will change existing database contents.
  • This PR introduces a breaking change to existing installations.

Summary

This change adds an app version, git SHA, and upstream repo as config variables and uses these in the footer.

Linked issues

Description of changes

Part of the implementation of nodeinfo for ActivityPub needs an app version to be included in the requests to the end point. With this change, the app version can be queried programmatically.

Dev instances will now also include the commit SHA in the footer.

@Floppy
Copy link
Collaborator

Floppy commented May 21, 2024

Could you update lib/usage_report.rb to use this as well, so it's consistent?

@matthewbadeau matthewbadeau marked this pull request as draft May 21, 2024 14:34
@matthewbadeau matthewbadeau marked this pull request as ready for review May 23, 2024 13:53
@matthewbadeau
Copy link
Contributor Author

👋 @Floppy I've pulled it back out of draft. Usage reports now report the currently running version even in dev. Though the code is a bit weird, I explained my reasoning here

@matthewbadeau matthewbadeau mentioned this pull request May 23, 2024
7 tasks
config/application.rb Outdated Show resolved Hide resolved
app/lib/usage_report.rb Outdated Show resolved Hide resolved
Copy link
Collaborator

@Floppy Floppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of suggestions to make the removal of docker tag prefixes and length of git sha more consistent.

@Floppy Floppy added the improvement Refactors and behind-the-scenes improvements label May 28, 2024
Copy link

codeclimate bot commented May 28, 2024

Code Climate has analyzed commit 7dbca64 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.7% (0.0% change).

View more on Code Climate.

@Floppy Floppy merged commit c487df3 into manyfold3d:main May 28, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Refactors and behind-the-scenes improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants