-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding app version as an attribute #2194
Adding app version as an attribute #2194
Conversation
Could you update lib/usage_report.rb to use this as well, so it's consistent? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of suggestions to make the removal of docker tag prefixes and length of git sha more consistent.
Code Climate has analyzed commit 7dbca64 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 86.7% (0.0% change). View more on Code Climate. |
Checklist
🚨 Please review the guidelines for contributing to this repository. 🚨
Warnings
Summary
This change adds an app version, git SHA, and upstream repo as config variables and uses these in the footer.
Linked issues
Description of changes
Part of the implementation of nodeinfo for ActivityPub needs an app version to be included in the requests to the end point. With this change, the app version can be queried programmatically.
Dev instances will now also include the commit SHA in the footer.