Add Shrine storage engine #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
Floppy
force-pushed
the
shrine
branch
3 times, most recently
from
a9452c4
to
a5aa2f0
Compare
…tly done, using model path
and reorder model and library so they're made before that happens
…or bounding box test
|
upload doesn't actually deal with data structures at all at the moment, it just dumps the files on disk and runs a scan. So that's fine. |
|
This all seems to be working, which is pretty surprising! Going to bake it in testing for a while, but I think it can merge in and go onto my personal environment. |
|
Code Climate has analyzed commit 833b47c and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 93.2% (50% is the threshold). This pull request will bring the total coverage in the repository to 86.2% (0.1% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrating Shrine to make storage provider-agnostic, and enable a few other features. Ground work for #1670.
Things to still change: