Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely reset user session on logout #2279

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

Floppy
Copy link
Collaborator

@Floppy Floppy commented Jun 18, 2024

Devise doesn't completely reset the session cookie, it just resets the stuff inside it; we will nuke it from orbit instead (it's the only way to be sure).

@Floppy Floppy added improvement Refactors and behind-the-scenes improvements security labels Jun 18, 2024
@Floppy Floppy enabled auto-merge June 18, 2024 12:38
Copy link

codeclimate bot commented Jun 18, 2024

Code Climate has analyzed commit 9910009 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.1% (-0.1% change).

View more on Code Climate.

@Floppy Floppy merged commit f0267f4 into main Jun 18, 2024
10 checks passed
@Floppy Floppy deleted the reset-session-on-logout branch June 18, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Refactors and behind-the-scenes improvements security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant