Allow visitors to view public models without logging in #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| <%= paginate @models %> | ||
| <% end %> | ||
| <div class="row row-cols-1 row-cols-md-2 row-cols-lg-3 mb-4"> | ||
| <%= render ModelComponent.with_collection(@models, can_edit: @can_edit, can_destroy: @can_destroy) %> |
There was a problem hiding this comment.
Render path contains parameter value
|
Code Climate has analyzed commit 461912c and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 90.7% (50% is the threshold). This pull request will bring the total coverage in the repository to 86.5% (0.0% change). View more on Code Climate. |
truecharts-admin
referenced
this pull request
in truecharts/public
Sep 4, 2024
….77.0@fe5892f by renovate (#25917) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/manyfold3d/manyfold](https://redirect.github.com/manyfold3d/manyfold) | minor | `0.76.1` -> `0.77.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>manyfold3d/manyfold (ghcr.io/manyfold3d/manyfold)</summary> ### [`v0.77.0`](https://redirect.github.com/manyfold3d/manyfold/releases/tag/v0.77.0) [Compare Source](https://redirect.github.com/manyfold3d/manyfold/compare/v0.76.1...v0.77.0) Now you can control who you share your stuff with - even the entire world if you want! You can grant per-item viewing, editing, or owner permissions, and you can grant them to all local users, individual users, or the general public so your stuff can be viewed without an account. By default, new and existing content will be available to view by all local users, which is the same as previous versions. But, admins can change that default in settings to make new items private instead. #### What's Changed ##### ✨ New Features ✨ - Allow federation on single-user instances by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2565](https://redirect.github.com/manyfold3d/manyfold/pull/2565) - Add rich per-user and per-object permission controls by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2588](https://redirect.github.com/manyfold3d/manyfold/pull/2588) - Set owner permissions for uploaded models by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2592](https://redirect.github.com/manyfold3d/manyfold/pull/2592) - Let admin choose default permissions for new items by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2598](https://redirect.github.com/manyfold3d/manyfold/pull/2598) - Show sharing settings on edit forms for Model, Creator and Collection by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2605](https://redirect.github.com/manyfold3d/manyfold/pull/2605) - Set sharing & permissions on model, creator, and collection edit pages by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2606](https://redirect.github.com/manyfold3d/manyfold/pull/2606) - Allow visitors to view public models without logging in by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2607](https://redirect.github.com/manyfold3d/manyfold/pull/2607) ##### 🛠️ Other Improvements 🛠️ - Upgrade to latest alpine release by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2584](https://redirect.github.com/manyfold3d/manyfold/pull/2584) - Update to Ruby 3.3.4 by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2586](https://redirect.github.com/manyfold3d/manyfold/pull/2586) - Rename default roles for greater clarity alongside ReBAC permissions by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2593](https://redirect.github.com/manyfold3d/manyfold/pull/2593) - Translation updates (particularly de) by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2599](https://redirect.github.com/manyfold3d/manyfold/pull/2599) - DRY up some older code with concerns by [@​Floppy](https://redirect.github.com/Floppy) in [https://github.com/manyfold3d/manyfold/pull/2611](https://redirect.github.com/manyfold3d/manyfold/pull/2611) **Full Changelog**: manyfold3d/manyfold@v0.76.1...v0.77.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC42Ny4yIiwidXBkYXRlZEluVmVyIjoiMzguNjcuMiIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJhdXRvbWVyZ2UiLCJ1cGRhdGUvZG9ja2VyL2dlbmVyYWwvbm9uLW1ham9yIl19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2220