Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show public tags when logged out #2627

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Only show public tags when logged out #2627

merged 1 commit into from
Sep 5, 2024

Conversation

Floppy
Copy link
Collaborator

@Floppy Floppy commented Sep 5, 2024

resolves #2619

@Floppy Floppy added bug Something isn't working security labels Sep 5, 2024
Copy link

codeclimate bot commented Sep 5, 2024

Code Climate has analyzed commit 9d15e4b and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Security 2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.8% (0.2% change).

View more on Code Climate.

@Floppy Floppy merged commit 72704a1 into main Sep 5, 2024
11 checks passed
@Floppy Floppy deleted the hide-tags branch September 5, 2024 16:38
truecharts-admin added a commit to truecharts/charts that referenced this pull request Sep 5, 2024
….77.2@dc37c27 by renovate (#25982)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/manyfold3d/manyfold](https://redirect.github.com/manyfold3d/manyfold)
| patch | `0.77.1` -> `0.77.2` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>manyfold3d/manyfold (ghcr.io/manyfold3d/manyfold)</summary>

###
[`v0.77.2`](https://redirect.github.com/manyfold3d/manyfold/releases/tag/v0.77.2)

[Compare
Source](https://redirect.github.com/manyfold3d/manyfold/compare/v0.77.1...v0.77.2)

This release brings a few privacy improvements after the initial release
of public sharing in v0.77.0; you can no longer predict URLs of models,
and private tags are hidden.

#### What's Changed

##### 🔒 Security 🔒

- Change ID numbers in URLs to more secure randomised strings by
[@&#8203;Floppy](https://redirect.github.com/Floppy) in
[manyfold3d/manyfold#2625
- Only show public tags when logged out by
[@&#8203;Floppy](https://redirect.github.com/Floppy) in
[manyfold3d/manyfold#2627

##### 🐛 Bug Fixes 🐛

- Restore automatic login in single user mode by
[@&#8203;Floppy](https://redirect.github.com/Floppy) in
[manyfold3d/manyfold#2626

##### 🛠️ Other Improvements 🛠️

- Don't show sharing settings in single-user mode by
[@&#8203;Floppy](https://redirect.github.com/Floppy) in
[manyfold3d/manyfold#2628

**Full Changelog**:
manyfold3d/manyfold@v0.77.1...v0.77.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC42OC4wIiwidXBkYXRlZEluVmVyIjoiMzguNjguMCIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJhdXRvbWVyZ2UiLCJ1cGRhdGUvZG9ja2VyL2dlbmVyYWwvbm9uLW1ham9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security
Projects
Development

Successfully merging this pull request may close these issues.

Tags on unpermitted models still show in list
1 participant