refactor: add typing's for typescript #556
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typescript compiler in vs-code was giving lots of red squiggly lines so have added the needed types and type definition files to help when editing in the future.
added app/javascript/src/globals.d.ts so now you get intelligence when typing
There were also a few methods called that do not exist, I did check the three docs and also initially wrapped them in a try/catch block and they threw, so removed them also.
bbox.dispose()
centre.dispose()
bsphere.dispose()
In app/javascript/src/model_edit.ts
removed the maxitem= null as this is the default, and ts requires a number if a value is supplied
In package.json added a script option to run the ts-standard as used in husky so you can now do a: yarn run lint:ts
Would it be useful to run a tslint and prettier and or add a config to the project to keep things tidy and consistent? I'm not a ruby guy so not shure how it does things just yet.