Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support windows #13

Closed
manzt opened this issue Oct 23, 2024 · 6 comments
Closed

Support windows #13

manzt opened this issue Oct 23, 2024 · 6 comments

Comments

@manzt
Copy link
Owner

manzt commented Oct 23, 2024

Should be straightforward to add, just need to fight with CI a bit to understand what the issues are.

@manzt
Copy link
Owner Author

manzt commented Oct 27, 2024

Need to use subprocess in for win32 systems because execvp does not exist.

@ATL2001
Copy link
Contributor

ATL2001 commented Nov 27, 2024

super cool project, I've got the run command working on windows over here on my end, want me to open a PR?

@manzt
Copy link
Owner Author

manzt commented Nov 27, 2024

Glad to hear it! Yes, that would be amazing--thank you for offering to work on a contribution. The reason we don't officially support windows is mostly because I don't have a machine to try out myself, and CI tests were failing on windows. Feel free to open a PR and we can go from there

@ATL2001
Copy link
Contributor

ATL2001 commented Nov 28, 2024

I seem to have celebrated too early, I've got it opening the notebook in jupyterlab without issue, but when I shutdown jupyterlab it doesn't exit cleanly. it's complaining about not being able to delete ~juv\juv\tmp8f06lo3r\nbsignatures.db, which I think must be related to the temp dir created in the setup of the jupyter data dir. I'll fool around with it some more and see if I can get part that working too, but probably not today, I've got turkey to eat 😄🦃.

@manzt
Copy link
Owner Author

manzt commented Nov 28, 2024

no problem! happy turkey day—thanks again for your willingness to take some of this on when you can

@manzt
Copy link
Owner Author

manzt commented Dec 4, 2024

Closing for now, thanks to #54!

@manzt manzt closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants