Support windows with juv run
#54
Conversation
…rlab, and added raw string identifier before the notebook path in case the notebook's path has a \t in it, so that doesnt get turned into a tab
There was a problem hiding this comment.
Thanks for the awesome contribution! Sorry it took me so long for the review-preparing for my phd defense next week.
Just a couple of comments that hopefully we can get addressed quickly! Thanks again.
PS: Also when finished, you can run uv run ruff format to format the files so the linting checks pass as well.
|
I thought I had run ruff format before committing stuff, but I'm sure I did this time! good luck on the defense! 👍 |
|
happy to help! thanks for making it in the first place! I can't wait to show it off to some people, do you have any idea when the windows stuff will be available from pypi?
|
|
Shipped in |
|
Whoops, there was a bug where |
I only had to make a few code tweaks to get the code working on my windows box for firing up the subprocess, and I added raw string syntax for the notebook path in case the notebook's path has a \t in it so it doesnt change the \t into a tab. or a \u into a unicode escape etc. and I added
ignore_cleanup_errors=Trueto all the tempdirectory usage because without it, an error would throw anytime I shutdown jupyterlab because the nbsignatures.db of jupyter was locked.To get the tests to pass I had to replace the pipes at the end of some of the lines with the pipe symbol from my keyboard (I'm not going to pretend to be an encoding expert, but when I did a find/replace on the pipe symbols in the existing code with the pipe symbol on my keyboard, magically the tests passed for me)
let me know what you think!