Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Avoid importing types from top-level @zarrita/storage #146

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

manzt
Copy link
Owner

@manzt manzt commented Jan 17, 2024

Changes

import { type ... } from "@zarrita/storage";

to

import type { ... } from "@zarrita/storage"

so the import is dropped by TypeScript in the build output. Prevents bundlers from typing to import from @zarrita/storage.

@manzt manzt merged commit 9245629 into main Jan 17, 2024
2 checks passed
@manzt manzt deleted the export-type branch January 17, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant