missing class attributes on wrapper functions #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd_yarn/acorn-5.7.4 Bump acorn from 5.7.3 to 5.7.4
simllll
changed the title
simllll
changed the title
simllll
force-pushed
the
fix/merging-attributes
branch
from
88cbe38 to
a553672
Compare
|
That's strange. Never realised that it behaves like that. But this seems to me like a bug in the server side rendering. |
|
@maoberlehner can you share your thoughts on why you think this component will be obsolete with Vue 3? I'm deciding whether I should aggressively optimize my Nuxt.js app with this component or hold off on that. I can't seem to find any info on lazy hydration being planned for Vue 3. |
|
See https://twitter.com/youyuxi/status/1265684355420225537 for example. |
|
Very cool, thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this happens only when using the wrapper functions for hydration and not by using a tag.
e.g. you have a
<CustomComponentA class="xyz" />and CustomComponentA has
<div class="blub"></div>as template.Currently only "xyz" is applied while the component is not hydrated, with this regular class merging is happening and the final result class is "xyz blub".
I've added a test for this scenario.
Without the patch following scenarios happen:
SSR (correct):
before hydration (wrong, this also causes some flickering):
after hydration (correct again):
with this patch missing classes (missing in vnode, but are available in $el) are applied to the loading component.
@maoberlehner please let me know what you think of this issue.
thanks
simon