define STRICT_R_HEADERS, include float.h, adjust dbl eps constant #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Maogui,
As you know from yesterday's email (to which you already responded -- much appreciated), your CRAN package atakrig uses Rcpp, and uses in (just one file) definitions of DOUBLE_EPS that would go away if we enabled STRICT_R_HEADERS -- as we would like to. Please see the discussion at
RcppCore/Rcpp#898RcppCore/Rcpp#1158 and the links therein for more context.By simply including the standard header <float.h> and defining STRICT_R_HEADERS we can switch to DBL_EPSILON as the email patch and, for easier use, PR here show.
It would be lovely if you could apply this. There is no strong urgency: we aim to get this done over all affected packages in the space of a few months. If you apply it, would you mind dropping me a note by email or swinging by
RcppCore/Rcpp#898RcppCore/Rcpp#1158 to confirm?Many thanks for your help, and I hope you continue to find Rcpp helpful. Please don't hesitate to ask if you have any questions.
Edit 2021-04-29: Link to 1158 instead of 989