Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove app from the old folder when drag it to a new one #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sindweller
Copy link
Contributor

when drag an app from a folder to another(or create a new folder), remove it from its last folder at the same time.

@maoschanz
Copy link
Owner

maoschanz commented Jan 22, 2020

No that's a feature, a folder an app can be in several folders so i did this behavior by design.

But I agree it can be weird to some people, so i would accept the merge request if it's an option

@maoschanz
Copy link
Owner

Mmmmh i'm not even sure i would merge it actually, i agree with the idea of this option but there has to be a better way of doing that than relying on DragAndDrop.OVERLAY_MANAGER

@Sindweller
Copy link
Contributor Author

get it, i'll look for a better way.

@maoschanz maoschanz added dnd drag-and-drop related issues enhancement prefs features and bugs related to the prefs window, but not to the extension itself labels Jan 27, 2020
@Sindweller
Copy link
Contributor Author

add an option
prefs
I have trouble with finding another way to get the opened folder's id in appfolderDialog.js and extension.js without using DragAndDrop.OVERLAY_MANAGER, do you have any suggestion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dnd drag-and-drop related issues enhancement prefs features and bugs related to the prefs window, but not to the extension itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants