Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection options applied when defining it, not changeable afterwards #583

Open
maoschanz opened this issue Feb 13, 2023 · 0 comments
Open
Labels
enhancement ideas to improve existing features selection Everything related to the selection management
Milestone

Comments

@maoschanz
Copy link
Owner

Use case

user realizes the 'selection-extract' or the 'selection-color' is wrong. To realize that, they have already defined the selection pixbuf: sadly, those options are applied at the time of the 'define' operation, so the app expects them to unselect, change the value, and start all over again

Suggested solution

damn idk, i'm at work i don't have time for this, i'll think about that later

grouping the related selection operations with an id, retroactively change the 'define' operation, and rebuild the selection pixbuf from the history in on_options_changed??

Possible drawbacks

huge change to how the selection works = hard as hell = bugs everywhere

Possible alternatives

no

@maoschanz maoschanz added enhancement ideas to improve existing features selection Everything related to the selection management labels Feb 13, 2023
@maoschanz maoschanz added this to the 1.4.0 milestone Feb 13, 2023
maoschanz added a commit that referenced this issue Feb 15, 2023
@maoschanz maoschanz modified the milestones: 1.4, 1.6 Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ideas to improve existing features selection Everything related to the selection management
Projects
None yet
Development

No branches or pull requests

1 participant