Fix advanced video options dialog box duplicate field name #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes a duplicate 'Label8' field name (shared with the 'Shadow Quality' setting) to 'Label12', used by 'Color Correction', which keeps it consistent with its field definition's name.
The issue this fixes is the 'Shadow Quality' label being removed when modifying this resource file using the VGUI Build Mode editor (
SHIFT+CTRL+ALT+B) and saving it without editing either label, as the duplicate field name overrides(?) the 'Shadow Quality' label's field name and causes it to get removed. This issue is also present in Half-Life 2.This is unlikely to break any existing mods.