Fix ViewPunch random for AR2 #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blixibon
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
It seems a bit strange to open this PR now considering the MP branch port is not yet part of the main develop branch, and this also doesn't fix the same issue occurring in the singleplayer weapon_ar2 (even though it only uses the standard RandomInt and might not trigger an assertion failure).
Changes to the main develop branch will eventually be merged into the MP port anyway though, and I can apply this change to the singleplayer AR2 myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wrong usage of SharedRandomInt (-12 < -8).
Does this PR close any issues?
Should fixes assert in vstdlib in debug build and correct random on x axis.
PR Checklist
developbranch OR targets another branch with a specific goal in mind