Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed warnings about conversions between soundlevel_t and float #248

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

Mechami
Copy link

@Mechami Mechami commented Sep 24, 2023

This replaces the macros ATTN_TO_SNDLVL and SNDLVL_TO_ATTN with inline functions that properly handle conversions between float and soundlevel_t. Eliminates a large number of warnings when compiling with GCC.


Does this PR close any issues?

No.

PR Checklist

  • My PR follows all guidelines in the CONTRIBUTING.md file
  • My PR targets a develop branch OR targets another branch with a specific goal in mind

This replaces the macros ATTN_TO_SNDLVL and SNDLVL_TO_ATTN with inline functions that properly handle conversions between float and soundlevel_t. Eliminates a large number of warnings when compiling with GCC.
@Mechami
Copy link
Author

Mechami commented Sep 24, 2023

Tested with GCC 12.2.0. Relevant warnings are enabled when using the -Wconversion flag.

@Blixibon Blixibon merged commit db1b687 into mapbase-source:develop Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants